Update thank you image with high five - #809
Merged
Merged
Conversation
begedin
approved these changes
Nov 30, 2016
begedin
left a comment
begedin
left a comment
Contributor
There was a problem hiding this comment.
I think this looks good to merge, but there's the one comment that you might wanna give a try. I think it would work, but I'm not sure.
|
|
||
| let resetTimer = run.later((function() { | ||
| set(that, 'reset', false); | ||
| }), 1); |
Contributor
There was a problem hiding this comment.
Could probably use an arrow function instead of storing context into that. That should preserve the this from within the arrow function.
Contributor
There was a problem hiding this comment.
Also, I believe run.later can receive the context as an argument to, so that might be an option.
joshsmith
force-pushed
the
update-thank-you-image
branch
from
November 30, 2016 17:38
6fbdeab to
e9ce7f9
Compare
WenInCode
pushed a commit
that referenced
this pull request
Jan 26, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Updates the thank you page to use a high five instead of the fireworks.
This could probably be simplified some. Would love feedback on how to simplify further.